depositOrDrop now accepts slice #2494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
IntegratedQuantum
pushed a commit
that referenced
this pull request
Jan 24, 2026
This is extracted from: #2506 (comment) Initially this was only supposed to be a helper function, but as I wanted to improve the abstraction it grew into a struct to avoid namespace pollution. This will also be helpful if #2506 is not accepted, as I have at least one other slice refactor that currently copies this code (#2494), and we may extend additional functions to slices or make more operations use the same priority system.
IntegratedQuantum
requested changes
Jan 24, 2026
Member
IntegratedQuantum
left a comment
IntegratedQuantum
left a comment
There was a problem hiding this comment.
Please rebase to include changes from #2515 and fix formatting
Wunka
force-pushed
the
depositOrDropSlice
branch
from
f762d22 to
3ac98cf
Compare
Contributor
Author
done |
IntegratedQuantum
approved these changes
Jan 24, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #2483 together these two are the last to slice refactors I need to do for #2324
So if these refactors shall be continued for other payloads there should maybe be an issue.
As with the
tryCraftingrefactor the priority code is almost just copied over.And also as with the
tryCraftingrefactor I will keep #2324 up to Date with this PR.